This repository has been archived by the owner on Jun 6, 2020. It is now read-only.
Add getticks #44
Merged
Add getticks #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
glennsl
reviewed
Feb 13, 2020
Et7f3
reviewed
Feb 16, 2020
| @@ -795,6 +795,14 @@ CAMLprim value resdl_SDL_WaitTimeoutEvent(value vTimeout) { | |||
| CAMLreturn(ret); | |||
| } | |||
|
|
|||
| CAMLprim value resdl_SDL_GetTicks() { | |||
| CAMLparam0(); | |||
There was a problem hiding this comment.
A function that has parameters or local variables of type value must begin with a call to one of the CAMLparam macros and return with CAMLreturn, CAMLreturn0, or CAMLreturnT. In particular, CAMLlocal and CAMLxparam can only be called after CAMLparam.
Here the macro seem useless. I think you should be able to benefit from cheap call with [@noalloc] if you remove the macro.
20.11.2 https://caml.inria.fr/pub/docs/manual-ocaml/intfc.html#sec476 but it is fine otherwise.
There was a problem hiding this comment.
Oh, neat. Yeah that sounds like a good idea.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way of getting the value of the timer used for timestamps in input events. Will allow for proper sampling with libscroll