Separate drop events

[zbaylin]

As discussed in revery-ui/revery#833, it makes sense to differentiate between events that carry a file/text/path and those that don't.

This splits dropEvent into dropEvent and dropNotificationEvent. dropNotificationEvent is for when SDL is simply notifying that a drop is about to/has taken place through either DROPBEGIN or DROPCOMPLETE. dropEvent is for when there is information about the actual items being dropped.

This is a very simple change, but I definitely agree with both @glennsl and @bryphe that it improves clarity for these events!

[glennsl]

Looks great! Seems to even make the implementation here simpler!

I think you might have gone a bit too hard on the lockfiles though.

[zbaylin]

Looks great! Seems to even make the implementation here simpler!

I think you might have gone a bit too hard on the lockfiles though.

Yeah not sure what happened there. That was just the result of me running esy install 🤔. Is there anything you think I should do?

[bryphe]

Looks great, Zach! Thanks for going the extra mile and updating this API. Sorry I missed this reviewing it the first time around!

[bryphe]

Will publish this once it is in 👍

[zbaylin]

Sounds good! I'll wait for this to pass CI and then I'll merge it in!

[glennsl]

Yeah not sure what happened there. That was just the result of me running esy install thinking. Is there anything you think I should do?

./update-lockfiles.sh usually fixes these kinds of issues

[zbaylin]

Yeah not sure what happened there. That was just the result of me running esy install thinking. Is there anything you think I should do?

./update-lockfiles.sh usually fixes these kinds of issues

Does that exist here? Using find doesn't turn up anything.

[glennsl]

Hmm, I guess it doesn't. There's only one other sandbox here though, so just running esy @js install should do it then. Hopefully.

[zbaylin]

Hmm, I guess it doesn't. There's only one other sandbox here though, so just running esy @js install should do it then. Hopefully.

No go 😕. The git status after running that is empty 🤔.

[zbaylin]

Deleting the lock directories and running esy i again also produces the same lockfiles, so I think it's okay..? Not sure what else I would do.

[glennsl]

I guess so. Weird. If any dependency had been updated to drop a bunch of dependencies I'd expect esy.lock/index.json to have changed as well.

[bryphe]

Published 2.10.3028 👍