Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: add test code #1

Merged
merged 5 commits into from
Sep 23, 2019
Merged

debug: add test code #1

merged 5 commits into from
Sep 23, 2019

Conversation

haya14busa
Copy link
Member

No description provided.

@@ -0,0 +1,4 @@

function s:test()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Unused variable: s:test (see :help E738)

@@ -0,0 +1,4 @@

function s:test()
echo "Hello from reviewdog!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Prefer single quoted strings (see Google VimScript Style Guide (Strings))

@@ -0,0 +1,4 @@

function s:test()
let x = "Hello from reviewdog!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:x (see Anti-pattern of vimrc (Scope of identifier))

@@ -0,0 +1,4 @@

function s:test()
let x = "Hello from reviewdog!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Unused variable: x (see :help E738)

@@ -0,0 +1,4 @@

function s:test()
let x = "Hello from reviewdog!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Prefer single quoted strings (see Google VimScript Style Guide (Strings))

@haya14busa haya14busa merged commit b496258 into master Sep 23, 2019
@haya14busa haya14busa deleted the test branch September 23, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant