CacheBackend: Use a configurable setting to specify cache key #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarzi
reviewed
Dec 8, 2022
The internal cache key used to write to and read from the cache backend could conflict with the main application. By introducing a Django setting it allows the developer to specify one different from the default value.
Flauschbaellchen
force-pushed
the
cache-backend-health-key
branch
from
11cb07a
to
9b026b5
Compare
Flauschbaellchen
changed the title
Flauschbaellchen
changed the title
|
@skarzi Any news on this? I've resolved the threads as no more work needs to be done. |
|
@Flauschbaellchen I am not a maintainer of this package, just a contributor. I think this PR could be merged (and thank you - I am running your changes from this PR on prod in some of my projects for ~1 month 👍). @frankwiles can you take a look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a static class variable allows applications using django-health-check as a 3rd-party package to read the key's identifier used to read/write the cache entry.
This is in particular useful, if the application needs to know which keys are written from other packages and are not part of the application logic itself.