Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-19 - add support for OTP 24 / elixir 1.12 #14

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

gharnly
Copy link
Contributor

@gharnly gharnly commented Sep 12, 2022

The crypto functions in OTP have been revised with deprecations introduced in OTP 23 and the old versions have been completely removed in OTP 24. See: https://www.erlang.org/doc/general_info/deprecations.html#otp-23

As such this PR:

  • Adds support for both the old and the new API which will allow this package to be used in systems running OTP 24 and higher
  • Relaxed the elixir requirement so that systems using this package can upgrade to elixir 1.12 or higher

QA
I tested using asdf to have multiple local versions of elixir running. Add a .tools-versions file to the root of the project with these contents:

erlang 24.3.4.4
elixir 1.12.3-otp-24

Then run mix test. On master this will fail but on this branch it will pass.

To confirm it still works on elixir 1.11 / OTP 23 update your .tools-versions to:

erlang 23.3.4.5
elixir 1.11.4-otp-23

and run mix test

Copy link
Contributor

@jangromko jangromko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally, with both versions of Elixir and OTP project has been compiled correctly, tests passed and docs have been generated without any issues — everything looks good. 🦭

@gharnly gharnly merged commit 8fe0704 into revzilla:master Sep 12, 2022
@gharnly gharnly deleted the PLAT-19 branch September 12, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants