Make Video Processing Configurable #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes video to always process and not use passthrough as a fallback unless explicitly supplied as a compression override
This reverts commit 7bdb160.
…s-all-video-uploads
zeph-cohen10
requested review from
iirovi-rs,
MikkoKuivanenRS and
aylwing-rewardstyle
| @@ -210,7 +210,15 @@ open class LibraryMediaManager { | |||
| // 5. Configuring export session | |||
| let videoIsCropped = cropRect.size.width < abs(videoSize.width) || cropRect.size.height < abs(videoSize.height) | |||
|
|
|||
| let presetName = compressionTypeOverride ?? (videoIsCropped || videoIsTrimmed || videoIsRotated || (shouldMute && videoNeedsProcessing) ? YPConfig.video.compression : AVAssetExportPresetPassthrough) | |||
| var presetName = "" | |||
There was a problem hiding this comment.
Just a nit, this could be let presetName: String since it always gets inited in if-else.
There was a problem hiding this comment.
@MikkoKuivanenRS Updated 82209d1
MikkoKuivanenRS
approved these changes
Mar 15, 2024
…-without-passthrough Fix Slow Mo Processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes video processing configurable through a new
YPConfigoption. If this new config option is set by the client then processing will always occur and will prioritize using any providedcompressionTypeOverride. If this config option is not set then normal processing rules apply.