Add include_beta_states flag to utilities endpoint #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure is the Node version thing, not an actual test failure... I'm looking into it |
|
Fixed in #236 |
mariabajzek
approved these changes
Dec 11, 2023
mmezher
reviewed
Dec 11, 2023
| utilities: getUtilitiesForLocation(location), | ||
| utilities: getUtilitiesForLocation( | ||
| location, | ||
| request.query.include_beta_states ?? false, |
There was a problem hiding this comment.
Would this ever be null/undefined? I see that the default option is already set to false.
There was a problem hiding this comment.
(I see this present in many places where I'd expect there to always be a value, so perhaps I'm misunderstanding what default vals in the schema do in TS?)
There was a problem hiding this comment.
It's a little gap in the library we use to convert JSON Schema to TS types: ThomasAribart/json-schema-to-ts#153
mmezher
approved these changes
Dec 11, 2023
## Description Now that we have a fallback to returning all of a state's utilities from `authorities.json` in the absence of state-specific logic in `utilities-for-location.ts`, we need a way to gate states. Makes sense to use the same logic as `/calculator`. ## Test Plan `yarn test`. Locally request utilities for CT zip code 06033 with and without the flag. Make sure results are the same for RI (02861) with and without the flag.
oyamauchi
force-pushed
the
owen.util-flag
branch
from
59dc164
to
bf9b8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have a fallback to returning all of a state's utilities
from
authorities.jsonin the absence of state-specific logic inutilities-for-location.ts, we need a way to gate states. Makes senseto use the same logic as
/calculator.Test Plan
yarn test. Locally request utilities for CT zip code 06033 with andwithout the flag. Make sure results are the same for RI (02861) with
and without the flag.