-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 Platform bug squashing #1178
Merged
Merged
🐞 Platform bug squashing #1178
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2cba615
disable click to open blockdialog when showing createForm
shahrishabh7 95a6367
update
shahrishabh7 1550727
remove useeffect
shahrishabh7 29a91b1
remove useeffet
shahrishabh7 ce51810
remove space
shahrishabh7 cabf4d8
merged changes
shahrishabh7 6e77112
dont show workflows on plus button click
shahrishabh7 b040214
merge asim edits
shahrishabh7 f923d5a
handle pane double click
shahrishabh7 9884f89
remove prints from useworkflow
shahrishabh7 89cbae0
updated
shahrishabh7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ import { type NextPage } from "next"; | |
import Image from "next/image"; | ||
import { useRouter } from "next/router"; | ||
import { serverSideTranslations } from "next-i18next/serverSideTranslations"; | ||
import React, { useState } from "react"; | ||
import React, { useEffect, useState } from "react"; | ||
import { RiBuildingLine, RiStackFill } from "react-icons/ri"; | ||
import { RxHome, RxPlus } from "react-icons/rx"; | ||
|
||
|
@@ -71,6 +71,13 @@ const WorkflowPage: NextPage = () => { | |
); | ||
|
||
const [open, setOpen] = useState(false); | ||
const [disableBlockDialog, setDisableBlockDialog] = useState(true); | ||
|
||
const onPaneClick = () => { | ||
if (!disableBlockDialog) { | ||
setOpen(true); | ||
} | ||
}; | ||
|
||
const changeQueryParams = async (newParams: Record<string, string>) => { | ||
const updatedParams = { | ||
|
@@ -89,6 +96,15 @@ const WorkflowPage: NextPage = () => { | |
const showLoader = !router.isReady || (isLoading && !!workflowId); | ||
const showCreateForm = !workflowId && router.isReady; | ||
|
||
useEffect(() => { | ||
if (showCreateForm) { | ||
setDisableBlockDialog(true); | ||
} | ||
else { | ||
setDisableBlockDialog(false); | ||
} | ||
}, [showCreateForm]); | ||
|
||
const onCreate = async (name: string) => { | ||
const data = await WorkflowApi.fromSession(session).create({ | ||
name: name, | ||
|
@@ -217,7 +233,7 @@ const WorkflowPage: NextPage = () => { | |
nodesModel={nodesModel} | ||
edgesModel={edgesModel} | ||
className="min-h-screen flex-1" | ||
onPaneClick={() => setOpen(true)} | ||
onPaneClick={onPaneClick} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed this to onPaneDoubleClick in a different commit, should be good to merge after fixing conflicts :) |
||
/> | ||
</> | ||
); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should remove use effect