-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ec2 tags to volumes and snapshots #314
Conversation
Thanks for the work here!
|
|
d1f2f89
to
69d836b
Compare
While testing this PR I’ve hit another issue:
Where:
Will look into it tomorrow |
Seen this before. I believe it was related to the region not supporting the API scheme that was specified. |
Just to note, I've update PR with default (no |
Hi @clintonskitson, Is this targeted for 0.3.2? |
@akutz I am going to review this one now. |
Hi @clintonskitson, Let me restate my question - is this a bugfix or some required enhancement? If not it should be pushed to 0.4 so 0.3.2 can be released ASAP. |
This is an enhancement, so let's move with 0.3.2. |
Hi @clintonskitson, That's fine, but has it been on the docket for a while? Unless it's required to accommodate some external thing it should be punted to 0.4. We're in the release train, and we need to minimize churn. Only bug fixes should be included at this time. |
Agreed @akutz |
@echupriyanov This actually tests out well, thank you for the work. Can you take a swing at updating the EC2 docs with the updated tag to make this PR complete? |
@clintonskitson Sure. Will do it tomorrow morning. |
69d836b
to
3ab1df9
Compare
Added |
Signed-off-by: Eugene Chupriyanov <tchu@tchu.ru>
@echupriyanov Nice job here, well done. |
NEW FEATURES - ScaleIO v2 support rexray#355 - EC2 Tags added to Volumes & Snapshots rexray#314 ENHANCEMENTS - Use of official Amazon EC2 SDK rexray#359 - Added a disable feature for create/remove volume rexray#366 - Added ScaleIO troubleshooting information rexray#367 BUG FIXES - Fixes URLs for documentation when viewed via Github rexray#337 - Fixes logging bug on Ubuntu 14.04 rexray#377 - Fixes module start timeout error rexray#376 - Fixes ScaleIO authentication loop bug rexray#375 THANK YOU - Philipp Franke (https://github.com/philippfranke) - Eugene Chupriyanov (https://github.com/echupriyanov) - Peter Blum https://github.com/oskoss) - Megan Hyland https://github.com/meganmurawski)
NEW FEATURES - ScaleIO v2 support rexray#355 - EC2 Tags added to Volumes & Snapshots rexray#314 ENHANCEMENTS - Use of official Amazon EC2 SDK rexray#359 - Added a disable feature for create/remove volume rexray#366 - Added ScaleIO troubleshooting information rexray#367 BUG FIXES - Fixes URLs for documentation when viewed via Github rexray#337 - Fixes logging bug on Ubuntu 14.04 rexray#377 - Fixes module start timeout error rexray#376 - Fixes ScaleIO authentication loop bug rexray#375 THANK YOU - Philipp Franke (https://github.com/philippfranke) - Eugene Chupriyanov (https://github.com/echupriyanov) - Peter Blum https://github.com/oskoss) - Megan Hyland https://github.com/meganmurawski)
NEW FEATURES - ScaleIO v2 support #355 - EC2 Tags added to Volumes & Snapshots #314 ENHANCEMENTS - Use of official Amazon EC2 SDK #359 - Added a disable feature for create/remove volume #366 - Added ScaleIO troubleshooting information #367 BUG FIXES - Fixes URLs for documentation when viewed via Github #337 - Fixes logging bug on Ubuntu 14.04 #377 - Fixes module start timeout error #376 - Fixes ScaleIO authentication loop bug #375 THANK YOU - Philipp Franke (https://github.com/philippfranke) - Eugene Chupriyanov (https://github.com/echupriyanov) - Peter Blum https://github.com/oskoss) - Megan Hyland https://github.com/meganmurawski)
NEW FEATURES - ScaleIO v2 support #355 - EC2 Tags added to Volumes & Snapshots #314 ENHANCEMENTS - Use of official Amazon EC2 SDK #359 - Added a disable feature for create/remove volume #366 - Added ScaleIO troubleshooting information #367 BUG FIXES - Fixes URLs for documentation when viewed via Github #337 - Fixes logging bug on Ubuntu 14.04 #377 - Fixes module start timeout error #376 - Fixes ScaleIO authentication loop bug #375 THANK YOU - Philipp Franke (https://github.com/philippfranke) - Eugene Chupriyanov (https://github.com/echupriyanov) - Peter Blum https://github.com/oskoss) - Megan Hyland https://github.com/meganmurawski)
…pport Missing AWS Config Support for EBS driver
Now rexray only lists volumes and snapshot with specific tag/value.
Tag is defined in
drivers/storage/ec2.go
driver:Tag value can be defined in
rexray/config.yml
:Default value is
rexray
.