Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic CI/CR #1

Merged
merged 4 commits into from
Jun 1, 2020
Merged

Basic CI/CR #1

merged 4 commits into from
Jun 1, 2020

Conversation

m-242
Copy link
Collaborator

@m-242 m-242 commented May 23, 2020

We need to test the auto-release, and it only runs on master.

@m-242 m-242 requested a review from rfc2119 May 23, 2020 09:41
@rfc2119
Copy link
Owner

rfc2119 commented May 23, 2020

Github Workflows looks pretty nice! I'll be reviewing this shortly, since I have some breaking changes on master right now

.github/workflows/auto-release.yml Outdated Show resolved Hide resolved
.github/workflows/auto-release.yml Show resolved Hide resolved
.github/workflows/lint-and-test.yml Show resolved Hide resolved
Copy link
Owner

@rfc2119 rfc2119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I need to get some tests done before merging this

@rfc2119
Copy link
Owner

rfc2119 commented May 27, 2020

Ok, so I think we need to do a more testing setup rather than go test ./.... I've pushed some tests, and as you can see here in

serverTest = "http://127.0.0.1:8090/"

I run my tests against a local development server, since the service at transfer.sh is outdated. The needed steps to do before go test are as follows:

  1. grab a binary release from the original repo (e.g latest)
  2. change directory into the release location and issue:
transfer.sh --provider=local --listener :8090 --temp-path=/tmp/ --basedir=/tmp/

What do you think @m-242 ?

@m-242
Copy link
Collaborator Author

m-242 commented May 28, 2020

I like the idea of having a "real-life like" testing, but grabbing the binaries seems both costly and hard to setup properly.
I think that having a "request generating function" that we test on is much easier, and gets us faster testing. One big disadvantage is that we would have to update tests by hand according to transfer.sh and other file servers evolution.
On the other side, we don't need to test the standard libraries functions, and having tests relying on go test allows us not to care about things we cannot act on, and would be really hard to detect properly (what if the repo changes location ? what if github's release server is down while we test ? etc...).
Both these methods have problems, and I'm not too sure which is the most reliable/easiest to use.

@rfc2119 rfc2119 merged commit a20570a into master Jun 1, 2020
@rfc2119 rfc2119 removed the need-tests label Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants