Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PATCH /users/{email} not updating values inside the database #516

Conversation

grindarius
Copy link
Contributor

@grindarius grindarius commented Dec 19, 2023

✅ DoD

(use na when API docs (Release notes, etc) do not need to be updated)

📝 Summary

  • Update PATCH /users/{email} endpoint to return 204 instead of 200 on success call
  • Update the return type of updateAuth0User function the return [body, statusCode] instead of just the body

📸 Examples

none

🛑 Problems

none

💡 More ideas

none

@grindarius grindarius self-assigned this Dec 19, 2023
@grindarius grindarius linked an issue Dec 19, 2023 that may be closed by this pull request
Copy link
Contributor

@rassokhin-s rassokhin-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@rassokhin-s rassokhin-s merged commit 955aa39 into develop Dec 19, 2023
3 checks passed
@rassokhin-s rassokhin-s deleted the bug/515-patch-usersemail-returns-500-but-auth0-names-got-changed branch December 19, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PATCH users/{email} returns 500 but Auth0 names got changed
2 participants