Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation files due to change to random number generator changes #42

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

lrennels
Copy link
Collaborator

@lrennels lrennels commented Apr 5, 2024

  • Using Julia v1.6 and Commit d470ae6 all regression tests were passing.
  • After this it seems that the comparison validation files were updated to use v1.9, and all commits since then have been versioning updates etc. but nothing to the core code base.
  • Regression tests on commits following that update of validation files, using v1.9, do not pass, so these files must have been updated incorrectly. This PR will correct that error.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.46%. Comparing base (9aa3357) to head (b1dacfd).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   81.46%   81.46%           
=======================================
  Files          22       22           
  Lines        1106     1106           
=======================================
  Hits          901      901           
  Misses        205      205           
Flag Coverage Δ
unittests 81.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrennels lrennels merged commit 6471f48 into main Apr 5, 2024
4 of 15 checks passed
@lrennels lrennels deleted the validation-data-update branch April 5, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants