Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/latest/: use an absolute redirect, update tests #30

Merged
merged 3 commits into from
Aug 22, 2019

Conversation

abrasive
Copy link
Contributor

@abrasive abrasive commented Aug 21, 2019

This avoids an issue where the redirect is interpreted as a relative
URL.
This is caused by an update in one of the dependencies.
Resolves #28.

While I'm at it, updated one of the tests, because recent versions of
Werkzeug return a 308 for a permanent redirect. This is like a 301, but
preserves the request, including if it is a POST.

This fixes the tests on CI where it doesn't use the Pipenv.lock.

This avoids an issue where the redirect is interpreted as a relative
URL.
This is caused by an update in one of the dependencies.
Resolves rgalanakis#28.

While I'm at it, updated one of the tests, because recent versions of
Werkzeug return a 308 for a permanent redirect. This is like a 301, but
preserves the request, including if it is a POST.
@abrasive abrasive changed the title latest: use an absolute redirect, update tests /latest/: use an absolute redirect, update tests Aug 21, 2019
@abrasive
Copy link
Contributor Author

I took the liberty of giving Python2 the flick from tox.ini - while it's admirable that you have supported it so far, judging by the CI logs, some of the dependencies have moved on! My apologies if that was presumptious of me.

@rgalanakis
Copy link
Owner

This is great! One ask- since this is a big backwards-compat change, can you add a CHANGELOG.md file and note that version 2.0 is Python 3.3+? I'll cut a version 1.0 before releasing this version.

Since this is not a library, and not so actively developed, and 2.x is near EOL, I'm okay finally removing it. I wanted to hold on because this tool is mostly for enterprises and they move slow :)

@abrasive
Copy link
Contributor Author

I certainly can, do you want to start the CHANGELOG at 1.0 and I'll rebase on top of that?

@rgalanakis rgalanakis merged commit 2d840c2 into rgalanakis:master Aug 22, 2019
@rgalanakis
Copy link
Owner

Thanks for this! Happy that CI is passing again 🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linking to latest doesn't work
2 participants