Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename modules to High.Class, High.Instruction, and so on #3

Open
rgrig opened this issue Jan 4, 2012 · 3 comments
Open

rename modules to High.Class, High.Instruction, and so on #3

rgrig opened this issue Jan 4, 2012 · 3 comments
Assignees

Comments

@rgrig
Copy link
Owner

rgrig commented Jan 4, 2012

I would like to put all code for the high-level representation of the bytecode in a module High that has submodules Class, Instruction, Field, Attribute, Method, and so on.

At the moment, we have both the old high-level representation (Class, Instruction, Attribute, ....) and the new high-level representation (HighClass and its submodules HighInstruction, HighAttribute, ...) In a few instances I could not understand OCaml's name resolution rules when one has both module A and module B.A, so I think it's a bad idea to have both Instruction and High.Instruction. In other words, the renaming that I propose here should be done only after we get rid of the old high-level representation altogether.

@rgrig
Copy link
Owner Author

rgrig commented Jan 16, 2012

Related:
#5

@rgrig
Copy link
Owner Author

rgrig commented Apr 2, 2012

This waits on issue #16.

@rgrig
Copy link
Owner Author

rgrig commented Apr 2, 2012

I now prefer the following organization.

  • LowTypes contains the types for the low-level representation of the bytecode
  • HighTypes contains the types for the high-level representation of the bytecode
  • Serializer contains functions that read/write thye low-level representation
  • Coder contains functions that convert between the low-level and the high-level representations
  • other stuff goes in other modules
  • keep the user interface small: by default if topl doesn't need it, then don't export it

@ghost ghost assigned rgrig Apr 2, 2012
rgrig added a commit that referenced this issue Apr 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant