Do not use or assume Base 64 encoding of cookies #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, only cookie values should be percent-decoded. The keys should be using the safe alphabet as per the spec. This fixes issue rgrinberg#57.
|
Thanks! |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Jan 4, 2019
CHANGES: - Switch to dune (rgrinberg/opium#88, anuragoni) - Keep the "/" cookie default and expose all cookie directives (rgrinberg/opium#82, @actionshrimp) - Do not assume base 64 encoding of cookies (rgrinberg/opium#74, @malthe) - Add caching capabilities to middleware (rgrinberg/opium#76, @mattjbray)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, only cookie values should be percent-decoded. The keys should be
using the safe alphabet as per the spec.
This fixes issue #57.