Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Relax URL validation #46

Open
luissquall opened this issue Jan 29, 2015 · 0 comments
Open

Relax URL validation #46

luissquall opened this issue Jan 29, 2015 · 0 comments

Comments

@luissquall
Copy link

Strange enough YUI 3.1.1 seed makes the following request, appending an unnecessary & to the URL:

http://yui.yahooapis.com/combo?3.1.1/build/widget/assets/skins/sam/widget.css&3.1.1/build/widget/assets/skins/sam/widget-stack.css&3.1.1/build/overlay/assets/skins/sam/overlay.css&

Their service ignores the ampersand, even when it is inserted multiple times, and fulfils successfully the request.

Given this behaviour is part of Yahoo's service, would you be willing to relax the validation, perhaps by removing the following lines from combohandler.js:

        if (fileTypes.indexOf('') > -1) {
            // Most likely a malformed URL, which will just cause
            // an exception later. Short-cut to the inevitable conclusion.
            return next(new BadRequest('Truncated query parameters.'));
        }
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant