-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gumbo] Entity Ö
is converted to Ö;
, leaving the semicolon behind
#114
Comments
I can't reproduce this. What version of Ruby and Sanitize are you using? |
@rgrove Sorry that my input got rendered to HTML. Here is the code version.
I'm using ruby 2.0.0p481, sanitize (3.0.0) Thank you for looking into this. |
Thanks. So, it's normal for the entity |
Yep, looks like this is a Gumbo parser bug. I'll try to get it fixed upstream. |
Ö
is converted to Ö;
, leaving the semicolon behind
Awesome! Glad you found the issue! |
@rgrove when will the next release be? Thanks! |
@dfguo Next step is to get a new Nokogumbo gem with the Gumbo fix: rubys/nokogumbo#11 Once that happens, I'll release Sanitize 3.0.1 with an updated Nokogumbo dependency. |
@dfguo Just pushed out the 3.0.1 gem with this fix. Edit: Correction, 3.0.2 has the fix. Looks like Nokogumbo 1.1.11 silently reverted the change we wanted. Oops! |
Awesome! Thanks! |
I'm not so sure why
Was this intentional? It breaks German characters by adding an extra ';'.
The text was updated successfully, but these errors were encountered: