Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pret merge Friday #2998

Merged
merged 9 commits into from
May 14, 2023
Merged

Conversation

Bassoonian
Copy link
Collaborator

No conflicts.

Description

Checksum before:
ff694e08a8c0d64dab6d02ea9bb3e2ff39a86c7f pokeemerald.gba
Checksum after:
0f9f612a68e703770fab0310d2136cb0d089a99d pokeemerald.gba

Discord contact info

Jasper#5206

@AsparagusEduardo
Copy link
Collaborator

Hmm, the checksum changed. Can you pinpoint if there was a BUGFIX added that could've done that?
I generally detail those instances, because I use the checksum to make sure that stuff didn't break.

Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, the checksum change was due to the AllocZeroed Macro introduced in #2698
imagen

@AsparagusEduardo AsparagusEduardo merged commit 15adbc8 into rh-hideout:upcoming May 14, 2023
@Bassoonian Bassoonian deleted the rhhpretmerge branch May 15, 2023 08:23
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants