Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sell value of 1/4 of an item's price, with config #3315

Merged
merged 21 commits into from
Oct 5, 2023

Conversation

kittenchilly
Copy link

@kittenchilly kittenchilly commented Sep 15, 2023

Description

SV nerfs selling, making it only give 1/4 of the item's price instead of 1/2. This adds that with a config.

Discord contact info

kittenchilly

src/item_menu.c Outdated Show resolved Hide resolved
src/data/items.h Outdated Show resolved Hide resolved
@kittenchilly
Copy link
Author

Should be reviewable again.

include/item.h Outdated Show resolved Hide resolved
@kittenchilly
Copy link
Author

All reviews applied.

include/config/item.h Outdated Show resolved Hide resolved
@kittenchilly
Copy link
Author

I accidentally messed up this PR by merging master into it.....

@AsparagusEduardo
Copy link
Collaborator

I accidentally messed up this PR by merging master into it.....

Instead of reverting, you could've waited until I merged master into upcoming

@kittenchilly
Copy link
Author

I accidentally messed up this PR by merging master into it.....

Instead of reverting, you could've waited until I merged master into upcoming

I already reverted the reversion, don't worry. I was just testing stuff out

@LOuroboros
Copy link
Collaborator

Uh, there's a couple of commits thrown in here that shouldn't really show up, like for example 093c653?

firefox_20231001_205543161

@kittenchilly
Copy link
Author

Uh, there's a couple of commits thrown in here that shouldn't really show up, like for example 093c653?

firefox_20231001_205543161

Like I said, I accidentally merged master into this, when master wasn't merged into upcoming yet. once that happens it should fix itself

@AsparagusEduardo AsparagusEduardo merged commit ab8bc6e into rh-hideout:upcoming Oct 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants