SpeciesInfo tests #3688
SpeciesInfo tests #3688
Conversation
| @@ -48948,6 +48949,7 @@ const struct SpeciesInfo gSpeciesInfo[] = | |||
| .categoryName = _("Drummer"), \ | |||
| .footprint = gMonFootprint_Rillaboom, \ | |||
| LEARNSETS(Rillaboom), \ | |||
| .formSpeciesIdTable = sRillaboomFormSpeciesIdTable, \ | |||
There was a problem hiding this comment.
I understand that they were missing from the base forms, but shouldn't they be in the Gigantamax forms also? The Mega Evolutions certainly seem to have the tables assigned to all forms, so we should probably be consistent (unless there's a reason not to be?)
There was a problem hiding this comment.
Yes, all forms of a species should have the table assigned.
There was a problem hiding this comment.
It's not at all clear here on GitHub, but this is a change to the RILLABOOM_MISC_INFO macro which is used by both SPECIES_RILLABOOM and SPECIES_RILLABOOM_GIGANTAMAX. So it should be applied to both the base form and the Gigantamax forms.
There was a problem hiding this comment.
Right, sorry, just woke up xD
There was a problem hiding this comment.
Apologies, my bad :) all good to go then!
There was a problem hiding this comment.
np! It's really difficult to see on GitHub!
Adds tests that verify appropriate invariants hold between the members of
gSpeciesInfo:.formSpeciesIdTable..targetSpeciesare to a species ID in.formSpeciesIdTable.Also corrects some small issues I noticed while writing and fixing these tests.
Closes #3689