[Community PR] Shadow Pokémon #4128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # asm/macros/battle_script.inc # include/battle_scripts.h # include/constants/battle_script_commands.h # include/constants/battle_string_ids.h # src/battle_message.c # src/battle_script_commands.c
# Conflicts: # asm/macros/event.inc # data/battle_scripts_1.s # data/script_cmd_table.inc # data/scripts/gift_pichu.inc # data/specials.inc # include/battle_scripts.h # include/constants/battle_string_ids.h # include/pokemon.h # include/trade.h # src/battle_gfx_sfx_util.c # src/battle_message.c # src/battle_util.c # src/egg_hatch.c # src/party_menu.c # src/pokemon.c # src/scrcmd.c # src/trade.c
…nto RHH/pr/feature/shadow_pokemon_moves # Conflicts: # asm/macros/battle_script.inc # data/battle_anim_scripts.s # data/battle_scripts_1.s # graphics/battle_anims/backgrounds/shadowstorm.pal # graphics/battle_anims/backgrounds/shadowstorm.png # include/battle_scripts.h # include/constants/battle_move_effects.h # include/constants/battle_script_commands.h # include/constants/battle_string_ids.h # include/constants/moves.h # include/pokemon.h # src/battle_controller_opponent.c # src/battle_controller_player.c # src/battle_message.c # src/battle_script_commands.c # src/data/pokemon/species_info.h # src/data/text/abilities.h # src/data/text/move_descriptions.h # src/data/text/move_names.h # src/pokemon.c # src/pokemon_summary_screen.c
# Conflicts: # data/battle_anim_scripts.s # data/battle_scripts_1.s # include/battle_scripts.h # include/constants/battle_move_effects.h # include/constants/trainers.h # include/data.h # src/battle_main.c # src/battle_script_commands.c # src/battle_setup.c # src/data/text/move_descriptions.h # src/data/text/move_names.h
Credit to BittersweetNSour
# Conflicts: # asm/macros/battle_script.inc # data/battle_anim_scripts.s # data/battle_scripts_1.s # graphics/interface/status_icons.png # include/battle_scripts.h # include/constants/battle.h # include/constants/battle_anim.h # include/constants/battle_move_effects.h # include/constants/battle_script_commands.h # include/constants/battle_string_ids.h # include/constants/party_menu.h # src/battle_anim_effects_3.c # src/battle_gfx_sfx_util.c # src/battle_message.c # src/battle_script_commands.c # src/battle_util.c # src/data/battle_anim.h # src/pokemon_summary_screen.c
Originally by Bitter
# Conflicts: # include/constants/battle_anim.h # include/constants/battle_move_effects.h # include/pokemon.h # src/battle_controller_player.c # src/battle_script_commands.c # test/test_runner.c
…xes' into _RHH_shadow/shadow # Conflicts: # include/pokemon.h
This reverts commit 8253723. # Conflicts: # include/constants/party_menu.h # include/pokemon.h # src/pokemon.c
# Conflicts: # README.md # asm/macros/battle_script.inc # asm/macros/event.inc # data/battle_anim_scripts.s # data/battle_scripts_1.s # data/script_cmd_table.inc # include/battle_controllers.h # include/battle_interface.h # include/battle_scripts.h # include/constants/battle_anim.h # include/constants/battle_move_effects.h # include/constants/battle_script_commands.h # include/constants/battle_string_ids.h # include/constants/moves.h # include/constants/trainers.h # include/data.h # include/pokemon.h # src/battle_controller_link_opponent.c # src/battle_controller_link_partner.c # src/battle_controller_opponent.c # src/battle_controller_player.c # src/battle_controller_player_partner.c # src/battle_controller_recorded_opponent.c # src/battle_controller_recorded_player.c # src/battle_controller_safari.c # src/battle_controller_wally.c # src/battle_gfx_sfx_util.c # src/battle_interface.c # src/battle_main.c # src/battle_message.c # src/battle_script_commands.c # src/battle_util.c # src/data/battle_anim.h # src/data/battle_moves.h # src/data/text/move_descriptions.h # src/data/text/move_names.h # src/data/trainer_parties.h # src/graphics.c # src/pokemon.c # src/pokemon_summary_screen.c # src/script_pokemon_util.c # src/trade.c
# Conflicts: # include/constants/battle_move_effects.h # src/data/battle_move_effects.h
25 tasks
# Conflicts: # data/battle_anim_scripts.s # data/battle_scripts_1.s # graphics/interface/status_icons.png # graphics_file_rules.mk # include/battle_scripts.h # include/constants/battle.h # include/constants/battle_anim.h # include/constants/battle_move_effects.h # include/constants/battle_script_commands.h # include/constants/battle_string_ids.h # include/constants/moves.h # include/constants/party_menu.h # include/constants/pokemon.h # include/data.h # src/battle_anim_effects_3.c # src/battle_gfx_sfx_util.c # src/battle_interface.c # src/battle_main.c # src/battle_message.c # src/battle_script_commands.c # src/battle_util.c # src/data/battle_move_effects.h # src/data/trainer_parties.h # src/data/trainers.h # src/pokedex.c # src/pokemon.c # src/pokemon_summary_screen.c # src/script_pokemon_util.c # test/battle/trainer_control.c
# Conflicts: # data/battle_anim_scripts.s # include/constants/battle_anim.h # src/battle_util.c # src/data/battle_anim.h
# Conflicts: # asm/macros/event.inc # data/battle_anim_scripts.s # data/battle_scripts_1.s # graphics_file_rules.mk # include/battle_interface.h # include/battle_scripts.h # include/constants/battle_anim.h # include/constants/battle_move_effects.h # include/constants/battle_script_commands.h # include/constants/battle_string_ids.h # include/constants/pokemon.h # include/data.h # include/pokemon.h # src/battle_anim_new.c # src/battle_controllers.c # src/battle_gfx_sfx_util.c # src/battle_interface.c # src/battle_main.c # src/battle_script_commands.c # src/battle_util.c # src/data/battle_anim.h # src/data/battle_move_effects.h # src/pokedex.c # src/pokemon.c # src/pokemon_summary_screen.c # src/scrcmd.c
|
Closing the PR for now, until we come back to work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the usage of the https://github.com/rh-hideout/pokeemerald-expansion-shadow/ repository.
It's labeled as "Community PR" as a way to invite other collaborators into contributing to it, similar to how #3249 (Gen 9 Species) was handled.
This is a very WIP branch, so many features aren't implemented and are buggy, so fixes are welcome!
Credits list:
FULL DESCRIPTION COMING SOON
Images
Discord contact info
AsparagusEduardo