Support generating external adapters #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rharter
reviewed
Jan 12, 2020
README.md
Outdated
| using `@Json` to define an alternate name for de/serialization. | ||
| Simply include auto-value-moshi in your project and annotate your target autovalue class with Moshi's | ||
| `@JsonClass` annotation. `generateAdpater` must be true, and the `generator` property value should | ||
| be `"avg"`. |
There was a problem hiding this comment.
Should be "autovalue", or at least "avm", right?
rharter
approved these changes
Jan 12, 2020
There was a problem hiding this comment.
Very nice.
This gets me wondering if there's a way for the generator property to be inferred, like a service locator in Moshi that effectively tries to find services that can generate the adapter, in this case AVM providing a generator for classes that are @JsonClass and @AutoValue annotated, otherwise falling back to it's own internal generator. That is most definitely a nice-to-have that's out of this scope, though, and possible not even worth it.
|
Possibly! R8 does support inlining servicelocator lookups so it's something we could look at. Will file an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #119
This uses moshi's native generated adapter lookup mechanism. To use, simply annotate the autovalue class with
@JsonClass(generateAdapter = true, generator = "avg")and then auto-value-moshi will generate a top-level adapter.