Upgrade dependencies and fix for ktor 1.3.0. #8
Conversation
| @@ -22,7 +24,9 @@ class MoshiConverter(private val moshi: Moshi = Moshi.Builder().build()) : Conte | |||
| val channel = request.value as? ByteReadChannel ?: return null | |||
| val source = channel.toInputStream().source().buffer() | |||
| val type = request.type | |||
| return moshi.adapter(type.javaObjectType).fromJson(source) | |||
| return withContext(Dispatchers.IO) { | |||
There was a problem hiding this comment.
I don't we should change the coroutine context. It is already a suspending function, so it will pick up the given context when executed.
There was a problem hiding this comment.
I bumped into this and did some investigation. Because fromJson() throws IOException, Intelij assumes it is doing a blocking call and warns that it is not safe to do in a coroutine. Using Dispatchers.IO silences this warning because it is "designed specifically to handle blocking calls".
I wasn't able to find any information on what ktor uses for ContentConverters. It is possible that it is already on using Dispatchers.IO, which mean calling it directly would be fine. But the IDE inspection doesn't have that context to know if it is a false positive.
I looked at the implementation of the of the ContentConverters for gson and serialization. Neither use IOException, so it is hard to tell if this is needed.
| @@ -1,3 +1,5 @@ | |||
| @file:Suppress("unused") | |||
There was a problem hiding this comment.
Ideally warnings would be suppressed at their specific site, to be clear about what is being suppressed, why, and to avoid accidentally suppressing useful warning messages.
build.gradle.kts
Outdated
| id("com.github.ben-manes.versions") version "0.39.0" | ||
| } | ||
| subprojects { | ||
| group = "com.github.cs125-illinois" |
There was a problem hiding this comment.
This need to change back to the original values from gradle.properties.
Fix dependency change to support ktor 1.3.0. Also upgrade kotlin and moshi dependencies, and fix test cases to support moshi 1.9.2.