feature/parallelism logging #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VascoSch92
reviewed
Apr 22, 2024
| @@ -65,7 +65,8 @@ def samples_from_model( | |||
| return self.samples_in_test_mode(total_points=total_points, model=model) | |||
|
|
|||
| logger.info( | |||
| "Generating initial samples of model, which are subject to prior limits and other constraints." | |||
| f"Generating initial samples of model, which are subject to prior limits and other constraints. " | |||
There was a problem hiding this comment.
Suggested change
| f"Generating initial samples of model, which are subject to prior limits and other constraints. " | |
| "Generating initial samples of model, which are subject to prior limits and other constraints. " | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
==========================================
+ Coverage 80.60% 80.75% +0.14%
==========================================
Files 198 198
Lines 14946 14979 +33
==========================================
+ Hits 12047 12096 +49
+ Misses 2899 2883 -16 ☔ View full report in Codecov by Sentry. |
Jammy2211
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaked logging for #956
May be insufficient or too loud - we can refine it over time