Build support for macOS/Darwin #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
closed this by deleting the head repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to compile the current master revision (7929f41) for macOS, I run into some small issues. These issues can be easily solved by including the correct dependencies and supplying valid search paths to the compiler suite.
I've extended the
Makefileso it can use clang and the correct search paths. When brew is installed on the macOS system this project is being built on, brew's prefix path will be used for building. Some things work different for Apple/macOS, so these changes had been implemented in a non-invasive way via define switches.Lastly, there was a minor issue in
dumpet/applepart.c, where a printf call did not take into consideration whether it's being built for 64- or 32-bit systems. This one was solved by implementing two versions of the call.