Skip to content

Commit

Permalink
Make sure we define the version for new symbols recently added...
Browse files Browse the repository at this point in the history
Because symbol versioning is a nightmare, this tool has shown that we've
got an error where we changed the version on some things by accident:

https://abi-laboratory.pro/tracker/compat_report/efivar/29/30/e3de7/abi_compat_report.html

Make those keep the 1.30 version forever.

Signed-off-by: Peter Jones <pjones@redhat.com>
  • Loading branch information
vathpela committed Feb 6, 2017
1 parent e756340 commit 4d4282e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
3 changes: 3 additions & 0 deletions src/error.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ efi_error_get(unsigned int n,

return 1;
}
__asm__(".symver efi_error_get,efi_error_get@LIBEFIVAR_1.30");

int
__attribute__((__visibility__ ("default")))
Expand Down Expand Up @@ -133,6 +134,7 @@ efi_error_set(const char *filename,
errno = ENOMEM;
return -1;
}
__asm__(".symver efi_error_set,efi_error_set@LIBEFIVAR_1.30");

void
__attribute__((__visibility__ ("default")))
Expand All @@ -157,3 +159,4 @@ efi_error_clear(void)
error_table = NULL;
current = 0;
}
__asm__(".symver efi_error_clear,efi_error_clear@LIBEFIVAR_1.30");
8 changes: 1 addition & 7 deletions src/libefivar.map.in
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,8 @@ LIBEFIVAR_0.24 {
efi_guid_cmp;
} LIBEFIVAR_0.0;

LIBEFIVAR_1.28 {
LIBEFIVAR_1.30 {
global: efi_error_set;
efi_error_get;
efi_error_clear;
} LIBEFIVAR_0.24;

LIBEFIVAR_1.29 {
} LIBEFIVAR_1.28;

LIBEFIVAR_1.30 {
} LIBEFIVAR_1.29;

0 comments on commit 4d4282e

Please sign in to comment.