Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document automerge #75

Merged
merged 6 commits into from
May 19, 2020
Merged

Document automerge #75

merged 6 commits into from
May 19, 2020

Conversation

mnuttall
Copy link
Collaborator

This PR provides documentation and Tekton samples showing how Pull Requests may be merged automatically where deemed appropriate.

@mnuttall mnuttall requested a review from dibbles May 12, 2020 13:24
Copy link
Contributor

@dibbles dibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor points for clarrification/discussion - I will attempt to test this later.

automerge/README.md Outdated Show resolved Hide resolved
- In `github-secret.yaml` replace `[your-github-token-with-repo-access]` with your base64-encoded token. Run this command to get the right string:

```sh
echo -n [your-token] | base64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You could have used stringData rather than data in the yaml file, then I do not believe you need to do the base64 conversion in advance. (I'm pretty sure if your yaml states stringData, kube does the base64 conversion when the yaml is applied - up to you whether you test this and change)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

automerge/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dibbles dibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got this going once I was on tekton v0.11.3 not 12 :)

@dibbles dibbles merged commit b4b4464 into rhd-gitops-example:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants