-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document automerge #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor points for clarrification/discussion - I will attempt to test this later.
automerge/README.md
Outdated
- In `github-secret.yaml` replace `[your-github-token-with-repo-access]` with your base64-encoded token. Run this command to get the right string: | ||
|
||
```sh | ||
echo -n [your-token] | base64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: You could have used stringData rather than data in the yaml file, then I do not believe you need to do the base64 conversion in advance. (I'm pretty sure if your yaml states stringData, kube does the base64 conversion when the yaml is applied - up to you whether you test this and change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got this going once I was on tekton v0.11.3 not 12 :)
This PR provides documentation and Tekton samples showing how Pull Requests may be merged automatically where deemed appropriate.