list major common keyboard layouts first

[sdp5]

Refer: rhbz#1158370
Depends: mike-fabian/langtable#11

This is an attempt to determine major keyboard layouts and place them first in the keyboard layouts selection list.
Hence lesser scroll for users.

To Do:

• determine better approach, if any
• few UI changes: include a separator
• code cleanups

[pep8speaks]

Hello @sundeep-anand! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file pyanaconda/ui/gui/spokes/keyboard.py:

Line 25:1: E402 module level import not at top of file

• In the file pyanaconda/ui/gui/xkl_wrapper.py:

Line 43:1: E402 module level import not at top of file
Line 46:1: E402 module level import not at top of file

Comment last updated at 2020-09-02 12:20:59 UTC

[jkonecny12]

Hello, nice work!

Just a small nitpick right now. First, let's wait until the langtable change will be decided and then we can start with the review and suggestions here.

[jkonecny12]

Jenkins, it's ok to test.

[sdp5]

Langtable changes are released and built as well.

Not sure why Rawhide tests failed.
Looking forward for suggestions/improvements.

Meanwhile I'll try to add a separator and clean up spokes/keyboard.py changes a bit.

[VladimirSlavik]

The gist of unit tests failure was AttributeError: module 'langtable' has no attribute 'list_common_keyboards' so that could be resolved now. Additional failures were reported by pylint:

E1101(no-member):/anaconda/pyanaconda/localization.py:384,11: get_common_keyboard_layouts: Module 'langtable' has no 'list_common_keyboards' member
W0612(unused-variable):/anaconda/pyanaconda/ui/gui/spokes/keyboard.py:101,8: AddLayoutDialog.compare_layouts: Unused variable 'show_str1'
W0612(unused-variable):/anaconda/pyanaconda/ui/gui/spokes/keyboard.py:102,8: AddLayoutDialog.compare_layouts: Unused variable 'show_str2'
W0611(unused-import):/anaconda/pyanaconda/ui/gui/spokes/keyboard.py:42,0: : Unused locale imported as locale_mod

Theoretically only the pylint stuff should remain now... if the langtable build already propagated all the way to our PR test workers. Let's see?

Jenkins, test this please.

[jkonecny12]

jenkins, test this please

[jkonecny12]

Langtable is now in the repositories so the main problem is gone the rest seems to be valid issue:

W0612(unused-variable):/anaconda/pyanaconda/ui/gui/spokes/keyboard.py:101,8: AddLayoutDialog.compare_layouts: Unused variable 'show_str1'
W0612(unused-variable):/anaconda/pyanaconda/ui/gui/spokes/keyboard.py:102,8: AddLayoutDialog.compare_layouts: Unused variable 'show_str2'
W0611(unused-import):/anaconda/pyanaconda/ui/gui/spokes/keyboard.py:42,0: : Unused locale imported as locale_mod

[jkonecny12]

Please ignore the test result now. New pylint version was released so we need to make adjustments to fix this.

[sdp5]

kindly review ..

[VladimirSlavik]

I don't know enough about this to approve, but code LGTM.

[poncovka]

The code looks good to me. Thanks!

[VladimirSlavik]

Code LGTM as far as I can tell...

[M4rtinK]

Made a couple screenshots of how this looks like in practice, sorted top of the list in the "ADD A KEYBOARD LAYOUT" dialog:

The divider between the major/common layouts and the less common ones:

[M4rtinK]

Looks good to me as well - thanks a lot! :)

[jkonecny12]

Looks good to me. Even thought this test is not really testing Anaconda code but let's fix that later.

Thanks for your contribution and for fixing this old bug!

[sdp5]

welcome, and thanks for merging