Allow to interrupt media verification (#1349152) #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M4rtinK
approved these changes
Jan 4, 2021
|
/packit build |
jkonecny12
approved these changes
Jan 4, 2021
poncovka
approved these changes
Jan 4, 2021
| <object class="GtkButton" id="doneButton"> | ||
| <property name="label" translatable="yes" context="GUI|Software Source|Media Check Dialog">_Done</property> | ||
| <object class="GtkButton" id="closeButton"> | ||
| <property name="label" translatable="yes" context="GUI|Software Source|Media Check Dialog">_Close</property> |
There was a problem hiding this comment.
Shouldn't it be called Cancel?
There was a problem hiding this comment.
Cancel is fine as well and makes more sense when the verification is in progress - changed.
Related: rhbz#1349152
jstodola
force-pushed
the
verification_close
branch
from
b611796
to
7216e45
Compare
|
Changed the label of the button from |
poncovka
approved these changes
Jan 5, 2021
|
/packit build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no button to stop media verification, for example when the progress is very slow.
Change the current "Done" button (usable only when the verification completes) to "Close" button, allowing to cancel the verification and closing the dialog window any time.
Related: rhbz#1349152