-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the RPM OSTree module to install the payload #3234
Use the RPM OSTree module to install the payload #3234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. But I don't think the comments can just go like that.
Call the _get_source method of a payload module to get a source object of the specified type or None.
Use the DBus API of the RPM OSTree module in the RPM OSTree payload class.
38ed35c
to
44abf48
Compare
Add the flatpak source to the RPM OSTree module if it is available. That is enough to install them on the target system.
Use sysroot and physroot in the installation tasks.
Make sure that the tasks use sysroot, physroot and data as expected.
44abf48
to
36fbbce
Compare
Improve the progress reporting messages in the InstallFlatpaksTask class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
/kickstart-test --testtype smoke |
/kickstart-test rpm-ostree |
Use the DBus API of the RPM OSTree module in the RPM OSTree payload class.