Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the RPM OSTree module to install the payload #3234

Merged
merged 6 commits into from
Mar 16, 2021

Conversation

poncovka
Copy link
Contributor

Use the DBus API of the RPM OSTree module in the RPM OSTree payload class.

@poncovka poncovka added master Please, use the `f39` label instead. manual testing required This issue can't be merged without manual testing labels Mar 11, 2021
Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. But I don't think the comments can just go like that.

pyanaconda/payload/rpmostreepayload.py Show resolved Hide resolved
pyanaconda/payload/rpmostreepayload.py Show resolved Hide resolved
Call the _get_source method of a payload module to get a source object
of the specified type or None.
Use the DBus API of the RPM OSTree module in the RPM OSTree payload class.
@poncovka poncovka force-pushed the f34-devel-rpm_ostree_module branch from 38ed35c to 44abf48 Compare March 16, 2021 13:11
Add the flatpak source to the RPM OSTree module if it is available.
That is enough to install them on the target system.
Use sysroot and physroot in the installation tasks.
Make sure that the tasks use sysroot, physroot and data as expected.
@poncovka poncovka force-pushed the f34-devel-rpm_ostree_module branch from 44abf48 to 36fbbce Compare March 16, 2021 16:24
Improve the progress reporting messages in the InstallFlatpaksTask class.
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@poncovka
Copy link
Contributor Author

/kickstart-test --testtype smoke

@poncovka
Copy link
Contributor Author

/kickstart-test rpm-ostree

@poncovka poncovka removed the manual testing required This issue can't be merged without manual testing label Mar 16, 2021
@poncovka poncovka merged commit fe16ca8 into rhinstaller:master Mar 16, 2021
@rvykydal rvykydal mentioned this pull request Jan 12, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
Development

Successfully merging this pull request may close these issues.

3 participants