Drop packit override for webui package build #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M4rtinK
added
f37
|
/kickstart-test --testtype smoke |
|
BTW, this should only be merged once #4268 that is adjusting the |
The anaconda-webui sub-package is gated by the spec file use_cockpit macro. So far we have changed this macro via packit to disable the anaconda-webui package from being build in the official Fedora builds. This is no longer necessary & we are ready for the anaconda-webui package to be part of the official Anaconda builds, so lets drop the override.
M4rtinK
force-pushed
the
master-drop_packit_config_webui_override
branch
from
5dfb94d
to
dddd5d0
Compare
|
/kickstart-test --testtype smoke |
|
Dependencies for the webui package have been adjusted, so this is no longer blocked. |
|
Hi @M4rtinK is there a reason why you want to have release notes for this PR? |
jkonecny12
removed
the
release note required
|
Added to release notes here #4759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anaconda-webui sub-package is gated by the spec file use_cockpit macro.
So far we have changed this macro via packit to disable the
anaconda-webui package from being build in the official Fedora builds.
This is no longer necessary & we are ready for the anaconda-webui
package to be part of the official Anaconda builds, so lets drop
the override.