Improve configuration of additional repositories in GUI #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poncovka
added
notable change
|
Additional repositories are hidden by default.
The configuration screen for the repositories is not available when there is nothing to show. We were not very good at disabling the configuration options + there was a bug + it is easier to hide them than disable them.
After adding or selecting a repository, this is a configuration page for http, https and ftp repositories.
This is a configuration page for nfs repositories with an example of the validation error.
This is a configuration page for other types of repositories.
This is a configuration page for treeinfo repositories.
|
rvykydal
approved these changes
Jan 12, 2023
Implement suggestions for additional repositories proposed at: rhinstaller#4257 * Replace the protocol selection with a drop-down menu of source actions. * Show only configuration options relevant to the selected source action. * Re-use the available proxy configuration dialog for the proxy configuration.
The function is no longer used.
The function is no longer used.
The method is no longer used.
The attribute is no longer used.
The method is no longer used.
The method is no longer used.
poncovka
force-pushed
the
master-additional_repo_gui_v2
branch
from
753b777
to
b361344
Compare
|
/kickstart-test --testtype smoke |
|
I am merging this pull request to unblock some follow-up work, but feel free to provide a review or a feedback anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement suggestions for additional repositories proposed at: #4257
Depends on:
TODO: