anaconda-diskroot: wait before dying on media check fail #5292
Conversation
If a modesetting driver has been loaded by the time the media check happens, halting the system (as we currently do immediately if the check fails) blanks the screen, which is confusing for the user. This adds a warning message and a 12-hour wait before the system is eventually halted, so the user can see the media check failure and (presumably) reboot and fix the medium. It also tweaks the text of the failure message not to call it a "CD check", since it's not 1998 any more. Resolves: rhbz#2246410 Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
cross-reference with dracutdevs/dracut#2545 , the same change in dracut (for the live path). |
|
btw, I'm not sure this is the best long-term fix, I was hoping someone had a better idea somehow. But I thought it was good enough for F39 at least, and wanted to submit it upstream before doing the downstream build. |
|
Is there any reasoning behind the 12 hours? |
|
/kickstart-test --testtype smoke |
Kinda, but it's ultimately pretty arbitrary. I was talking the issue over with @nirik (I asked for his thoughts on whether he preferred a sleep or just dropping to the emergency console) and he suggested it. I'd considered anything from one minute upwards. The scenario we're concerned about is someone starting the media check then going to do something else; we want them to see the error when they come back. So, how long to leave it? It's hard to say. I figure at least half an hour in case they go for lunch and get distracted, or something. But then if you're gonna leave it that long, why not...longer? Ultimately it's an arbitrary number. I'm not honestly sure this is the perfect fix for this, but we needed something for F39. The dracut folks had the same question over in dracutdevs/dracut#2545 . |
|
Do we want to move this to Rawhide maybe ? |
|
logically speaking it should be merged to F39 because I put it into F39 Final as a downstream patch. it wouldn't make much sense to remove it again with the next official F39 build. edit: that is, if we're going to merge it at all, it doesn't make sense to me to only merge it into Rawhide - since it already went into F39, F39 should keep it. If you think it was a terrible idea and you don't want to merge it anywhere and I shouldn't have put it in F39 Final, that's a different story. :D |
|
Well, I would assume yes. But only if you set mediacheck to true, which is not the default. |
|
A release is not needed, since this is patched in f39 already. I will port it to master as well. |
anaconda-diskroot: wait before dying on media check fail
If a modesetting driver has been loaded by the time the media
check happens, halting the system (as we currently do immediately
if the check fails) blanks the screen, which is confusing for
the user. This adds a warning message and a 12-hour wait before
the system is eventually halted, so the user can see the media
check failure and (presumably) reboot and fix the medium.
It also tweaks the text of the failure message not to call it a
"CD check", since it's not 1998 any more.
Resolves: rhbz#2246410