-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate vnc tui spokes to runtime DBUS #5710
Migrate vnc tui spokes to runtime DBUS #5710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am far from being expert in the backend but this looks a bit as an unwanted workaround.
The tui / gui places trying to access the vnc variable, should read it from the proxy runtime .
0725995
to
a61a8ad
Compare
a61a8ad
to
aea17af
Compare
aea17af
to
59e645e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to the bug in the commit message:
https://bugzilla.redhat.com/show_bug.cgi?id=2292556
/kickstart-tests --testtype smoke |
/build-image |
Images built based on commit 59e645e:
Download the images from the bottom of the job status page. |
59e645e
to
6e3cc9e
Compare
@adamkankovsky this still crashes. |
I already found it. When otps is used, the value is in a string otherwise it is secret data. I've already edited it. I apologize for the mistake. I tested it using kickstrat and this error could not be here. |
Resolves: Bug 2292556
6e3cc9e
to
a0f7e38
Compare
/build-image |
Images built based on commit a0f7e38:
Download the images from the bottom of the job status page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, code wise. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested also the ISO - works correctly with inst.tui inst.vnc inst.vncpassword
/kickstart-tests --testtype smoke |
No description provided.