Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate vnc tui spokes to runtime DBUS #5710

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

adamkankovsky
Copy link
Contributor

@adamkankovsky adamkankovsky commented Jun 18, 2024

No description provided.

Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am far from being expert in the backend but this looks a bit as an unwanted workaround.

The tui / gui places trying to access the vnc variable, should read it from the proxy runtime .

@adamkankovsky adamkankovsky changed the title Update existing ksdata with VNC data from DBUS Migrate vnc tui spokes to runtime DBUS Jun 18, 2024
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the bug in the commit message:
https://bugzilla.redhat.com/show_bug.cgi?id=2292556

@KKoukiou
Copy link
Contributor

/kickstart-tests --testtype smoke

@KKoukiou
Copy link
Contributor

/build-image

Copy link

Images built based on commit 59e645e:

  • boot.iso: success

Download the images from the bottom of the job status page.

@KKoukiou
Copy link
Contributor

@adamkankovsky this still crashes.
Screen Shot 2024-06-19 at 10 00 18

@adamkankovsky
Copy link
Contributor Author

@adamkankovsky this still crashes. Screen Shot 2024-06-19 at 10 00 18

I already found it. When otps is used, the value is in a string otherwise it is secret data. I've already edited it. I apologize for the mistake. I tested it using kickstrat and this error could not be here.

@KKoukiou
Copy link
Contributor

/build-image

Copy link

Images built based on commit a0f7e38:

  • boot.iso: success

Download the images from the bottom of the job status page.

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, code wise. :)

Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested also the ISO - works correctly with inst.tui inst.vnc inst.vncpassword

@KKoukiou
Copy link
Contributor

/kickstart-tests --testtype smoke

@KKoukiou KKoukiou merged commit 3cab9ec into rhinstaller:master Jun 21, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants