Fix broken locale support in console check #5714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New langtable-0.0.67-2 version introduced new scripts for some languages. That broke our tests because our code is expecting to have all the scripts supported by the console for the given locale. Based on the discussion with Mike Fabian who is maintainer of langtable we come to conclusion that we should check only for the first script for the given locale because it's the most significant one. This should fix our broken tests and mainly the code. Suggested-by: mike-fabian
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype keyboard,langauge |
|
/kickstart-test --testtype keyboard,language |
|
/kickstart-test --testtype language |
|
/kickstart-test --testtype keyboard |
M4rtinK
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New langtable-0.0.67-2 version introduced new scripts for some languages. That broke our tests because our code is expecting to have all the scripts supported by the console for the given locale.
Based on the discussion with Mike Fabian who is maintainer of langtable we come to conclusion that we should check only for the first script for the given locale because it's the most significant one.
This should fix our broken tests and mainly the code. https://github.com/rhinstaller/anaconda/actions/runs/9574624471
Suggested-by: mike-fabian