Make library O_DIRECT compatible #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain the need for these changes? I'm not sure about them at first glance, and am reluctant to do things like writing more than is needed. Also it would be good to break the leak fix out into a separate commit. |
Merged
squimrel
force-pushed
the
odirect
branch
2 times, most recently
from
dccccc0
to
50bc807
Compare
|
When a file (or even a block device) is opened with the O_DIRECT flag (too minimize cache effects) all buffers, seek, read and write operations have to be block aligned. Specific use-case: Don't merge this one I start to really dislike most of this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a memory leak.