You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The AttemptTimeLimiters and WaitStrategies classes have methods that take a (long, TimeUnit) pair, whereas StopStrategies#stopAfterDelay accepts only a long. Not a big deal, but slightly unfortunate from an API point of view.
How about aligning StopStrategies with the other two classes by introducing StopStrategies#stopAfterDelay(long, TimeUnit) and deprecating StopStrategies#stopAfterDelay(long)?
(I understand the some of the strategy interfaces also take only a long, but most users will not implement those themselves, and in any case those types are in some sense more "low level".)
The text was updated successfully, but these errors were encountered:
The
AttemptTimeLimiters
andWaitStrategies
classes have methods that take a(long, TimeUnit)
pair, whereasStopStrategies#stopAfterDelay
accepts only along
. Not a big deal, but slightly unfortunate from an API point of view.How about aligning
StopStrategies
with the other two classes by introducingStopStrategies#stopAfterDelay(long, TimeUnit)
and deprecatingStopStrategies#stopAfterDelay(long)
?(I understand the some of the strategy interfaces also take only a
long
, but most users will not implement those themselves, and in any case those types are in some sense more "low level".)The text was updated successfully, but these errors were encountered: