Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RetryerBuilder having protected constructor #76

Open
yogenyadav opened this issue Jul 5, 2017 · 2 comments
Open

RetryerBuilder having protected constructor #76

yogenyadav opened this issue Jul 5, 2017 · 2 comments

Comments

@yogenyadav
Copy link

Hi,
I want to extend RetryerBuilder and add a method like retryIfExceptionMessage which will retry on contents of the message.
@JensRantil
Copy link

Best practise is extension should be done through composition, not inheritance. Are you sure you simply can't implement a StopStrategy which also is a RetryListener and register your implementation on the builder?

@smartvolshell
Copy link

com.github.rholder.retry.RetryerBuilder#retryIfException(com.google.common.base.Predicate<java.lang.Throwable>)
this method to meet you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JensRantil @yogenyadav @smartvolshell