Migrating sonar #53
Merged
Migrating sonar #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherl0cks
force-pushed
the
migrating-sonar
branch
from
d378aca
to
0b016ac
Compare
sherl0cks
force-pushed
the
migrating-sonar
branch
from
0b016ac
to
27b50d9
Compare
oybed
reviewed
Nov 17, 2017
docker/sonarqube/sonar.properties
Outdated
| ldap.bindDn=${env:LDAP_BINDDN} | ||
| ldap.bindPassword=${env:LDAP_BINDPASSWD} | ||
| ldap.url=${env:LDAP_URL} | ||
| ldap.realm=${env:LDAP_REALM} |
There was a problem hiding this comment.
This one was "fixed" by Kevin a few days ago - please ensure it carries over:
https://github.com/rht-labs/openshift-sonarqube/pull/17/files
oybed
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #51
a few issues left, opened #56 for this.