-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge signal generation and other features #10
Conversation
This commit splits long files to smaller ones, introduces subdirectories and removes some superfluous extensions
Generates supporting code for GWeak Generate code to automatically consume floating references upon init Adds support for ommiting private types Ommits class generation for metatypes
* [Build/CI] Fix build until 5.4; add CI for macOS * Attempt: fix libffi missing in macOS build * Remove libffi brew; fix driver path * Add echo in order to debug * Fix the possible issue * Remove incorrect argument * Attempt to solve the issue by removing all priv memebers Co-authored-by: Mikoláš Stuchlík <mikolas.stuchlik@futured.app>
Compatibility with macOS was restored. Working demo could be found here https://github.com/mikolasstuchlik/Matika alongside for build instructions. There was an issue with macOS build which was resolved in a controversial manner - the issue is described here https://github.com/mikolasstuchlik/gir2swift/pull/7 in more detail. CI passed for both lates LTS Ubuntu and macOS. Since the issue of macOS build was addressed, the PR is no longer WIP and is officially proposed. |
Any obstacles left for reviewing (and potentially merging) this? |
No, at this moment I don't plan on changing this PR in a significant way. I look forward to a discussion about any aspect of the PR, since I have made a lot of (controversial) changes. I plan on updating READMEs and related projects (like HelloWorld) after that (before merge). I would like to ask you to set-up the Github Actions - the PR contains configuration file, but I apperently lack the authority to do so. The configuration in this PR requests build only at latest macOS and Ubuntu 20.04 with latest Swift and latest Gtk 3. I can add configuration for any other desired platforms. |
Here are some initial observations:
Some minor issues (in addition to the ones you mentioned earlier):
None of these are show stoppers. I'll probably merge this into a new development branch first. This gives us some more time to iron things out before unleashing everything to the greater public. |
This PR is WIP due to unserolved issues:
Issues addressed by this PR:
private=1
Partially implemented:
This PR is ment for initial "quick look" into my implementation. I took the liberty to separate gir2swift files and add some directories. I also used as of yet unreleased returnBuilders.
After the PR is accepted for a review: