Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue in order aprs string #6

Closed
pd9mwo opened this issue Jan 17, 2022 · 6 comments
Closed

issue in order aprs string #6

pd9mwo opened this issue Jan 17, 2022 · 6 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@pd9mwo
Copy link

pd9mwo commented Jan 17, 2022

look like there is an issue with the order to send to APRS-IS

PD9MWO-4>APRS,TCPIP*:@171407z5216.39N/00437.37E_110/004t049g012P000h83b10256L063Xaprs-weather-submit/1.4
but must be
PD9MWO-4>APRS,TCPIP*:@171407z5216.39N/00437.37E_110/004g012t049P000h83b10256L063Xaprs-weather-submit/1.4

the raw packets on aprs.fi
GOOD
2022-01-17 15:09:09 CET: PD9MWO-4>APRS,TCPIP*,qAC,T2EDM:@171408z5216.39N/00437.37E_049/004g012t049P000h83b10256L062Xaprs-weather-submit/1.4

ISSUE
2022-01-17 15:11:31 CET: PD9MWO-4>APRS,TCPIP*,qAC,T2EDM:@171411z5216.39N/00437.37E_084/007t049g002P000h83b10256L061Xaprs-weather-submit/1.4

the order is wrong here
can you please fix this ??

many thanks in advance
menno
pd9mwo

@pd9mwo
Copy link
Author

pd9mwo commented Jan 17, 2022

changes these lines in the aprs-wx.c file ( version 1.4 )

look like its working now
but can you please fix it ???

212         else {
213                 /*                    header_________ timestamp____pos__wc_ s_t__*/
214                 snprintf(result, 61, "%s>APRS,TCPIP*:@%.2d%.2d%.2dz%s/%s_%s/%s",
215                         p->callsign, now->tm_mday, now->tm_hour, now->tm_min,
216                         p->latitude, p->longitude, p->windDirection, p->windSpeed);
217         }
218
219         if (notNull(p->gust)) {
220                 strncat(result, "g", 1);
221                 strncat(result, p->gust, 3);
222         }
223
224         if (notNull(p->temperature)) {
225                 strncat(result, "t", 1);
226                 strncat(result, p->temperature, 3);
 227         }

@rhymeswithmogul rhymeswithmogul self-assigned this Jan 18, 2022
@rhymeswithmogul rhymeswithmogul added bug Something isn't working good first issue Good for newcomers labels Jan 18, 2022
@rhymeswithmogul
Copy link
Owner

It seems odd that APRS.fi would ignore the gust speed if it comes after the temperature -- but that wouldn't be the first time I've had to deviate from the specification to make that (wonderful) site happy. Could you link me to a raw packet that was not processed correctly?

@pd9mwo
Copy link
Author

pd9mwo commented Jan 18, 2022 via email

@rhymeswithmogul
Copy link
Owner

APRS.fi is not following the specification correctly, but I suppose I can switch the g parameter to be first.

@pd9mwo
Copy link
Author

pd9mwo commented Jan 18, 2022

APRS.fi is not following the specification correctly, but I suppose I can switch the g parameter to be first.

or use my solution in the second post ;-)

@rhymeswithmogul rhymeswithmogul added this to the v1.6 milestone Oct 27, 2022
rhymeswithmogul added a commit that referenced this issue Oct 27, 2022
I thought I did this already (back in version 1.5.1), but I suppose
I forgot about it.  Sorry, Menno.
@rhymeswithmogul
Copy link
Owner

Sorry, @pd9mwo. I could have sworn that I worked around this in version 1.5. It's fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants