Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actionlint returns different results depending on number of files checked #173

Closed
suo opened this issue Jul 8, 2022 · 0 comments
Closed

Actionlint returns different results depending on number of files checked #173

suo opened this issue Jul 8, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@suo
Copy link

suo commented Jul 8, 2022

Repro (with actionlint v1.6.12):

  1. Check out https://github.com/pytorch/pytorch @ c48e964a04f478ad002ec6f3dd8543d0373104cb
  2. Run actionlint .github/workflows/_linux-build.yml, observe a failure
  3. Run actionlint .github/workflows/_ios-build-test.yml .github/workflows/_linux-build.yml, observe no failure

For step 3, I would have expected actionlint to return a failure as well, as there is an issue in one of the files.
@suo suo mentioned this issue Jul 8, 2022
Closed
suo added a commit to pytorch/pytorch that referenced this issue Jul 8, 2022
@suo
[lint] fix actionlint linter
fb68037 
There seems to be a bug in actionlint when running it on multiple files
(reported here: rhysd/actionlint#173). This
was causing CI to be green even though there are local linter failures.

This PR:
1. Changes our usage of actionlint to work around the aforementioned
bug.
2. Fixes the linter failures introduced

[ghstack-poisoned]
suo added a commit to pytorch/pytorch that referenced this issue Jul 8, 2022
@suo
[lint] fix actionlint linter
e4d6ef9 
There seems to be a bug in actionlint when running it on multiple files
(reported here: rhysd/actionlint#173). This
was causing CI to be green even though there are local linter failures.

This PR:
1. Changes our usage of actionlint to work around the aforementioned
bug.
2. Fixes the linter failures introduced

ghstack-source-id: 198b1b1bc822b999983551e69ad11e3813e99a0b
Pull Request resolved: #81119
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this issue Jul 8, 2022
@suo @pytorchmergebot
[lint] fix actionlint linter (#81119)
6882717 
There seems to be a bug in actionlint when running it on multiple files
(reported here: rhysd/actionlint#173). This
was causing CI to be green even though there are local linter failures.

This PR:
1. Changes our usage of actionlint to work around the aforementioned
bug.
2. Fixes the linter failures introduced
Pull Request resolved: #81119
Approved by: https://github.com/malfet
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this issue Jul 8, 2022
@suo @pytorchmergebot
[lint] fix actionlint linter (#81119)
3f56a1b 
There seems to be a bug in actionlint when running it on multiple files
(reported here: rhysd/actionlint#173). This
was causing CI to be green even though there are local linter failures.

This PR:
1. Changes our usage of actionlint to work around the aforementioned
bug.
2. Fixes the linter failures introduced
Pull Request resolved: #81119
Approved by: https://github.com/malfet
facebook-github-bot pushed a commit to pytorch/pytorch that referenced this issue Jul 12, 2022
@suo @facebook-github-bot
[lint] fix actionlint linter (#81119) (#81119)
710a002 
Summary:
There seems to be a bug in actionlint when running it on multiple files
(reported here: rhysd/actionlint#173). This
was causing CI to be green even though there are local linter failures.

This PR:
1. Changes our usage of actionlint to work around the aforementioned
bug.
2. Fixes the linter failures introduced

Pull Request resolved: #81119
Approved by: https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/3f56a1b8c0e9038e80bb12ceab1aea7e114f6e09

Reviewed By: mehtanirav

Differential Revision: D37749460

Pulled By: suo

fbshipit-source-id: 32f321abd05c3d4863f813a5f6c75c8c70749c26
@rhysd rhysd added the bug Something isn't working label Aug 16, 2022
@rhysd rhysd closed this as completed in 311b0fc Aug 16, 2022
rhysd added a commit that referenced this issue Aug 21, 2022
@rhysd
add tests for checking local actions used by multiple workflows (#173)
cb3dfc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhysd @suo