Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks support #23

Closed
drts01 opened this issue Aug 6, 2021 · 5 comments 路 Fixed by #33
Closed

Add pre-commit hooks support #23

drts01 opened this issue Aug 6, 2021 · 5 comments 路 Fixed by #33
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@drts01
Copy link
Contributor

drts01 commented Aug 6, 2021

Making this available as a pre-commit hook, i.e. add .pre-commit-hooks.yaml would be awesome. 馃槃

@rhysd
Copy link
Owner

rhysd commented Aug 6, 2021

I'm not familiar with the tool. Do you mean you'd like to see an example configuration of the tool for actionlint?

@drts01
Copy link
Contributor Author

drts01 commented Aug 6, 2021

I would like a .pre-commit-hook.yaml to be added to the repo, so pre-commit users can point to this repo to use actionlint in git hooks. For example, hadolint - the Dockfile linting tool, has included one in their repo, https://github.com/hadolint/hadolint/blob/master/.pre-commit-hooks.yaml

It works similarly to how GitHub Actions can point to a repo w/ an action.yaml file.

@rhysd
Copy link
Owner

rhysd commented Aug 8, 2021

Thanks for the explanation. It makes sense. Could you make a PR for this?

@rhysd rhysd added enhancement New feature or request help wanted Extra attention is needed labels Aug 8, 2021
@drts01
Copy link
Contributor Author

drts01 commented Aug 14, 2021

Will do 馃槃

@rhysd
Copy link
Owner

rhysd commented Aug 14, 2021

Thank you. It's helpful because you're much more familiar with the tool than me. Please ensure to update docs/usage.md with its usage.

drts01 added a commit to drts01/actionlint that referenced this issue Aug 18, 2021
drts01 added a commit to drts01/actionlint that referenced this issue Aug 18, 2021
drts01 added a commit to drts01/actionlint that referenced this issue Aug 18, 2021
@rhysd rhysd closed this as completed in #33 Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants