Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Open pull request #11

Closed
talha131 opened this issue Feb 26, 2019 · 2 comments
Closed

Feature request: Open pull request #11

talha131 opened this issue Feb 26, 2019 · 2 comments

Comments

@talha131
Copy link

@rhysd thanks a lot for creating this program. It certainly made my life easier.

Request

Open pull request from command line.

  1. My remote is origin
  2. I am on branch test which is ahead of master by 1 commit
  3. git-brws --pr or a similar command should open pull request page

For example this page

talha131/tw-scripts-demo@master...jvm-dev

It has a create pull request button.

Currently nearest command is

$ git-brws master..test
$ git-brws master...test

But these pages do not have "Create Pull Request" button.

A comparison of URL shows that only git-brws master...test compares master against hash. If hash is replaced with branch name then "Create PR" button automatically appears.

@rhysd
Copy link
Owner

rhysd commented Feb 28, 2019

ok, it looks useful since currently git-brws only returns an error when existing PR is not found. Navigating to 'new pull request' page would make PR creation easier. I'll label this as 'enhancement'.

There are 2 possibilities for 'open new pull request' page when the repository is a fork.

  1. Open pull request within the repository
  2. Open pull request at the upstream respository of the fork

I think 2. should have higher priority since a fork repository is usually created for making a pull request.

@rhysd
Copy link
Owner

rhysd commented Apr 29, 2019

This feature was included in v0.11.0.

@rhysd rhysd closed this as completed Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants