Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs for directory paths should use /tree/ instead of /blob/ #25

Closed
rhysd opened this issue Aug 31, 2020 · 1 comment
Closed

URLs for directory paths should use /tree/ instead of /blob/ #25

rhysd opened this issue Aug 31, 2020 · 1 comment
Labels

Comments

@rhysd
Copy link
Owner

rhysd commented Aug 31, 2020

Repro

Run:

git brws .

Expected results

It opens https://github.com/{owner}/{repo}/tree/{hash}

Actual results

It opened https://github.com/{owner}/{repo}/blob/{hash}

Additional info

URLs for subdirectories (e.g. git brws ./src) are redirected from /blob/ URL to /tree/ URL automatically. However, only a root directory (e.g. git brws .) does not redirect the URL hence 404 error caused on a browser. I think git-brws should not rely on the redirect.

@rhysd rhysd added the bug label Aug 31, 2020
@rhysd rhysd changed the title URLs for directorie paths should use /tree/ instead of /blob/ URLs for directory paths should use /tree/ instead of /blob/ Aug 31, 2020
@rhysd
Copy link
Owner Author

rhysd commented Aug 31, 2020

TODO: Check behavior of GitLab and Bitbucket

@rhysd rhysd closed this as completed in 3743eea Sep 2, 2020
rhysd added a commit that referenced this issue Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant