Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DatabaseCleaner error when running RSpec #110

Closed
wants to merge 3 commits into from

Conversation

ribose-jeffreylau
Copy link
Contributor

As reported in #109 (comment)

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #110 (56a846a) into master (2391ea7) will decrease coverage by 0.25%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   99.46%   99.20%   -0.26%     
==========================================
  Files          24       24              
  Lines         371      376       +5     
==========================================
+ Hits          369      373       +4     
- Misses          2        3       +1     
Impacted Files Coverage Δ
spec/support/db_cleaner.rb 94.44% <87.50%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2391ea7...3a3a594. Read the comment docs.

@ribose-jeffreylau
Copy link
Contributor Author

This PR includes some modifications suggested in #107 (and in the links buried within), which seem to have solved the bundler version issues. @skalee maybe you'd want to include the changes in https://github.com/riboseinc/attr_masker/tree/use-best-bundler-in-gha first, then I can rebase these commits on them?

@skalee
Copy link
Contributor

skalee commented Mar 4, 2021

Thanks! I'll take a look. A few more maintenance updates are needed in this gem so I'll take care about them too.

@ribose-jeffreylau
Copy link
Contributor Author

Closing in favour of #116

@ribose-jeffreylau ribose-jeffreylau deleted the dbcleaner branch March 5, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants