Upgrade Rubocop to 0.51, and migrate to new Ribose style guide #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skalee
force-pushed
the
update-rubocop-and-style-guide
branch
from
1814cd0
to
95bdfef
Compare
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=========================================
+ Coverage 99.39% 99.4% +<.01%
=========================================
Files 23 23
Lines 332 334 +2
=========================================
+ Hits 330 332 +2
Misses 2 2
Continue to review full report at Codecov.
|
Here eval is expected, as it helps avoiding code duplications. Ruby's `require` won't work in gemfiles.
skalee
force-pushed
the
update-rubocop-and-style-guide
branch
from
95bdfef
to
7acde3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.