Use dumped-game-data.json from Data Dump mod #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swazrgb
force-pushed
the
use-data-dump
branch
2 times, most recently
from
0a3652c
to
b974c9e
Compare
|
The additional data included, but not yet used, is intended to be used for supporting blueprints. The mod source is available here: https://github.com/swazrgb/desynced-data-dump |
|
You can view what the generated files look like here: https://github.com/ribrdb/desynced-tools/actions/runs/8217131145/artifacts/1312038323 |
|
FYI, I am implementing blueprints which requires this: https://github.com/swazrgb/desynced-tools/tree/blueprints This PR could be dropped in favour of the blueprint one, which has more context. |
ribrdb
reviewed
Mar 15, 2024
Makes this data available both to code generation & runtime. Would like to eventually switch some of the code generation (methods.ts, dinstr.ts, etc) to runtime parsing of the dumped-game-data.json. Since the dumped-game-data.json can be included in the repository with permission from Stage, the resulting generated files have been gitignored to reduce merge conflicts resulting from changes to geninstr.ts and such. Developers, and CI, must now run `npm run generate` when switching branches or pulling new commits.
ribrdb
approved these changes
Mar 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes this data available both to code generation & runtime. Would like to eventually switch some of the code generation (methods.ts, dinstr.ts, etc) to runtime parsing of the dumped-game-data.json.
Since the dumped-game-data.json can be included in the repository with permission from Stage, the resulting generated files have been gitignored to reduce merge conflicts resulting from changes to geninstr.ts and such.
Developers, and CI, must now run
npm run generatewhen switching branches or pulling new commits.