Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of token locations and improve error reporting #8

Merged
merged 25 commits into from
Aug 8, 2023

Conversation

ricardoboss
Copy link
Owner

No description provided.

@ricardoboss ricardoboss linked an issue Aug 7, 2023 that may be closed by this pull request
@ricardoboss
Copy link
Owner Author

The exception report design was inspired by https://github.com/nunomaduro/collision:

image

Repository owner deleted a comment from github-actions bot Aug 7, 2023
@chucker
Copy link
Collaborator

chucker commented Aug 8, 2023

The exception report design was inspired by https://github.com/nunomaduro/collision:

image

Should we be more explicit about how the compiler interprets the code? E.g., "You're trying to assign "invalid", which is a string, to the variable a, which is a number."

@ricardoboss ricardoboss mentioned this pull request Aug 8, 2023
@ricardoboss
Copy link
Owner Author

Added tips for all exceptions:

image

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
StepLang 86% 70% 1318
Summary 86% (1331 / 1549) 70% (795 / 1141) 1318

Minimum allowed line rate is 30%

@ricardoboss ricardoboss merged commit b171480 into main Aug 8, 2023
9 checks passed
@ricardoboss ricardoboss deleted the issues/7-better-error-reporting branch August 8, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better tokenizing/parsing error feedback
2 participants