Skip to content
This repository has been archived by the owner on Jul 7, 2022. It is now read-only.

Devices does not have an icon #81

Closed
bilelmoussaoui opened this issue Jun 26, 2016 · 7 comments
Closed

Devices does not have an icon #81

bilelmoussaoui opened this issue Jun 26, 2016 · 7 comments

Comments

@bilelmoussaoui
Copy link
Contributor

The devices icon value is always None

devices = pb.devices
print(devices[0].icon)

will return a NoneType exception
@simonporter007
Copy link
Contributor

I guess this occurs on existing devices and not new devices created with pyshbullet py? Should be system by default on new devices. Will have to add the same in the devices constructor.

@bilelmoussaoui
Copy link
Contributor Author

@simonporter007 Yes :) Thanks!

@bilelmoussaoui
Copy link
Contributor Author

Why this have been closed ?

@kovacsbalu
Copy link
Collaborator

Because this fixed in c8fe677

@bilelmoussaoui
Copy link
Contributor Author

Well, the PR is not merged yet ;)

kovacsbalu added a commit that referenced this issue Jan 18, 2017
@kovacsbalu
Merge pull request #109 from bil-elmoussaoui/master
06b6c57 
fixes #79 and #81
@kovacsbalu
Copy link
Collaborator

Whoops :)
Thanks for your notice

@bilelmoussaoui
Copy link
Contributor Author

You're welcome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonporter007 @kovacsbalu @bilelmoussaoui